Revert of [EditCommandSource] Pass source from |Editor::Command| to |Editor::apply*()/insert*( (2/3)

Revert of [EditCommandSource] Pass source from |Editor::Command| to |Editor::apply*()/insert*()/...| (2/3) (patchset #2 id:40001 of https://codereview.chromium.org/2576903002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

Original issue's description:
> [EditCommandSource] Pass source from |Editor::Command| to |Editor::apply*()/insert*()/...| (2/3)
> 
> This is the sub-patch (2/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
> 
> This CL:
> 1. Added method |Editor::replaceSelectionForSpellChecker()| for
>    |SpellChecker::replaceMisspelledRange()| to hide editor details;
> 2. Passed command source from |Editor::Command| to various methods in |Editor|,
>    such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
>    |replaceSelectionWithText()| etc.
> 
> Note:
> It's OK to add extra |EditCommandSource| parameter to those methods because
> they are going to be moved to "EditorCommand.cpp" (according to the editing
> refactor doc), which means they should share the similar pattern as other
> |static execute*()| methods.
> 
> This CL shouldn't have any behavior change.
> 
> Next CL will pass command source down to |CompositeEditCommand| and
> |TypingCommand|.
> 
> Editing Refactor doc:
> https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14BNMFTB8ms9uedeArbw/edit?usp=sharing
> 
> BUG=673789
> 
> Committed: https://crrev.com/f6fddd7fab5cf706023fc4f2edbdfa4fdd93d56f
> Cr-Commit-Position: refs/heads/master@{#439010}

TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789
Review-Url: https://codereview.chromium.org/2635963004
Cr-Commit-Position: refs/heads/master@{#444085}
Committed: https://chromium.googlesource.com/chromium/src/+/5d43e0f5fb5702f1873a4e9e94ea0f418ded2406

[chongz, 2017-01-17 14:57:57]

Created Revert of [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3)

[chongz, 2017-01-17 14:58:16]

Description was changed from

==========
Revert of [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3) (patchset #2 id:40001 of
https://codereview.chromium.org/2576903002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

Original issue's description:
> [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3)
> 
> This is the sub-patch (2/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
> 
> This CL:
> 1. Added method |Editor::replaceSelectionForSpellChecker()| for
>    |SpellChecker::replaceMisspelledRange()| to hide editor details;
> 2. Passed command source from |Editor::Command| to various methods in
|Editor|,
>    such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
>    |replaceSelectionWithText()| etc.
> 
> Note:
> It's OK to add extra |EditCommandSource| parameter to those methods because
> they are going to be moved to "EditorCommand.cpp" (according to the editing
> refactor doc), which means they should share the similar pattern as other
> |static execute*()| methods.
> 
> This CL shouldn't have any behavior change.
> 
> Next CL will pass command source down to |CompositeEditCommand| and
> |TypingCommand|.
> 
> Editing Refactor doc:
>
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14B...
> 
> BUG=673789
> 
> Committed: https://crrev.com/f6fddd7fab5cf706023fc4f2edbdfa4fdd93d56f
> Cr-Commit-Position: refs/heads/master@{#439010}

TBR=tkent@chromium.org,xiaochengh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789
==========

to

==========
Revert of [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3) (patchset #2 id:40001 of
https://codereview.chromium.org/2576903002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

Original issue's description:
> [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3)
> 
> This is the sub-patch (2/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
> 
> This CL:
> 1. Added method |Editor::replaceSelectionForSpellChecker()| for
>    |SpellChecker::replaceMisspelledRange()| to hide editor details;
> 2. Passed command source from |Editor::Command| to various methods in
|Editor|,
>    such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
>    |replaceSelectionWithText()| etc.
> 
> Note:
> It's OK to add extra |EditCommandSource| parameter to those methods because
> they are going to be moved to "EditorCommand.cpp" (according to the editing
> refactor doc), which means they should share the similar pattern as other
> |static execute*()| methods.
> 
> This CL shouldn't have any behavior change.
> 
> Next CL will pass command source down to |CompositeEditCommand| and
> |TypingCommand|.
> 
> Editing Refactor doc:
>
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14B...
> 
> BUG=673789
> 
> Committed: https://crrev.com/f6fddd7fab5cf706023fc4f2edbdfa4fdd93d56f
> Cr-Commit-Position: refs/heads/master@{#439010}

TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789
==========

[chongz, 2017-01-17 14:58:25]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:58:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 15:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 15:00:05]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[chongz, 2017-01-17 15:34:35]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-01-17 15:34:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 17:48:53]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1484667275937770,
"parent_rev": "a7640ac4ec2abd8380cc8e8a8b7e3023f3746328", "commit_rev":
"5d43e0f5fb5702f1873a4e9e94ea0f418ded2406"}

[commit-bot: I haz the power, 2017-01-17 17:49:22]

Description was changed from

==========
Revert of [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3) (patchset #2 id:40001 of
https://codereview.chromium.org/2576903002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

Original issue's description:
> [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3)
> 
> This is the sub-patch (2/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
> 
> This CL:
> 1. Added method |Editor::replaceSelectionForSpellChecker()| for
>    |SpellChecker::replaceMisspelledRange()| to hide editor details;
> 2. Passed command source from |Editor::Command| to various methods in
|Editor|,
>    such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
>    |replaceSelectionWithText()| etc.
> 
> Note:
> It's OK to add extra |EditCommandSource| parameter to those methods because
> they are going to be moved to "EditorCommand.cpp" (according to the editing
> refactor doc), which means they should share the similar pattern as other
> |static execute*()| methods.
> 
> This CL shouldn't have any behavior change.
> 
> Next CL will pass command source down to |CompositeEditCommand| and
> |TypingCommand|.
> 
> Editing Refactor doc:
>
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14B...
> 
> BUG=673789
> 
> Committed: https://crrev.com/f6fddd7fab5cf706023fc4f2edbdfa4fdd93d56f
> Cr-Commit-Position: refs/heads/master@{#439010}

TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789
==========

to

==========
Revert of [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3) (patchset #2 id:40001 of
https://codereview.chromium.org/2576903002/ )

Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.

Original issue's description:
> [EditCommandSource] Pass source from |Editor::Command| to
|Editor::apply*()/insert*()/...| (2/3)
> 
> This is the sub-patch (2/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
> 
> This CL:
> 1. Added method |Editor::replaceSelectionForSpellChecker()| for
>    |SpellChecker::replaceMisspelledRange()| to hide editor details;
> 2. Passed command source from |Editor::Command| to various methods in
|Editor|,
>    such as |performDelete()|, |removeFormattingAndStyle()|, |applyStyle()|,
>    |replaceSelectionWithText()| etc.
> 
> Note:
> It's OK to add extra |EditCommandSource| parameter to those methods because
> they are going to be moved to "EditorCommand.cpp" (according to the editing
> refactor doc), which means they should share the similar pattern as other
> |static execute*()| methods.
> 
> This CL shouldn't have any behavior change.
> 
> Next CL will pass command source down to |CompositeEditCommand| and
> |TypingCommand|.
> 
> Editing Refactor doc:
>
https://docs.google.com/a/chromium.org/document/d/1i-f5ByGHIvTcvy2UEAvOtBK14B...
> 
> BUG=673789
> 
> Committed: https://crrev.com/f6fddd7fab5cf706023fc4f2edbdfa4fdd93d56f
> Cr-Commit-Position: refs/heads/master@{#439010}

TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789

Review-Url: https://codereview.chromium.org/2635963004
Cr-Commit-Position: refs/heads/master@{#444085}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d43e0f5fb5702f1873a4e9e94ea...
==========

[commit-bot: I haz the power, 2017-01-17 17:49:23]

Committed patchset #2 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/5d43e0f5fb5702f1873a4e9e94ea...

[tkent, 2017-01-17 23:03:41]

lgtm

[tkent, 2017-01-17 23:03:46]

lgtm