Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2635923002: [foozzie] Refactoring - move source hashing to main script (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Refactoring - move source hashing to main script BUG=chromium:673246 NOTRY=true Review-Url: https://codereview.chromium.org/2635923002 Cr-Commit-Position: refs/heads/master@{#42386} Committed: https://chromium.googlesource.com/v8/v8/+/310a89977347b5a70cd94aa9406e74d9b55e90b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M tools/foozzie/v8_foozzie.py View 3 chunks +16 lines, -1 line 0 comments Download
M tools/foozzie/v8_foozzie_test.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/foozzie/v8_suppressions.py View 7 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL
3 years, 11 months ago (2017-01-16 13:58:04 UTC) #3
mmoroz
LGTM
3 years, 11 months ago (2017-01-16 14:25:34 UTC) #4
tandrii(chromium)
lgtm
3 years, 11 months ago (2017-01-16 18:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635923002/1
3 years, 11 months ago (2017-01-16 19:51:59 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 19:53:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/310a89977347b5a70cd94aa9406e74d9b55...

Powered by Google App Engine
This is Rietveld 408576698