Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 26358010: Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, just to 0 or 1. (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, just to 0 or 1. BUG= R=mtklein Committed: https://code.google.com/p/skia/source/detail?r=11731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkOnce.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Stephen White
Committed patchset #1 manually as r11731 (presubmit successful).
7 years, 2 months ago (2013-10-11 16:45:56 UTC) #1
mtklein
7 years, 2 months ago (2013-10-11 16:49:48 UTC) #2
Message was sent while issue was closed.
On 2013/10/11 16:45:56, Stephen White wrote:
> Committed patchset #1 manually as r11731 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698