src/core/SkOnce.h - Issue 26358010: Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, just to 0 or 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkOnce.h

Issue 26358010: Use #if insteadof #ifdef DYNAMIC_ANNOTATIONS_ENABLED. It's always defined, just to 0 or 1. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkOnce.h

diff --git a/src/core/SkOnce.h b/src/core/SkOnce.h

index 26bf392d5610493ac76b599693ba57b27dabb0ca..d5dd9d925ba0f413b3922a7ba99a44720d0f7341 100644

--- a/src/core/SkOnce.h

+++ b/src/core/SkOnce.h

@@ -124,7 +124,7 @@ static void sk_once_slow(bool* done, SkBaseMutex* mutex, void (*once)(Arg), Arg

// ANNOTATE_BENIGN_RACE, it might make sense to pull that in as a dependency

// rather than continue to reproduce it here.

-#ifdef DYNAMIC_ANNOTATIONS_ENABLED

+#if DYNAMIC_ANNOTATIONS_ENABLED

// TSAN provides this hook to supress a known-safe apparent race.

extern "C" {

void AnnotateBenignRace(const char* file, int line, const volatile void* mem, const char* desc);

« no previous file with comments | « no previous file | no next file » | no next file with comments »