Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2635713002: Roll buildtools 7e08d331f1..9a947138bc (Closed)

Created:
3 years, 11 months ago by Dirk Pranke
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 7e08d331f1..9a947138bc In order to roll GN 5c18ca83ce..7c0e0135f9 (r442253:r443802) and pick up the following changes: 717182cd794a Fix a GN race condition. TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2635713002 Cr-Commit-Position: refs/heads/master@{#443805} Committed: https://chromium.googlesource.com/chromium/src/+/2592262cc9dc8ea6cbe00a69a9b25b37970dae13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
3 years, 11 months ago (2017-01-14 22:59:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635713002/1
3 years, 11 months ago (2017-01-14 22:59:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2592262cc9dc8ea6cbe00a69a9b25b37970dae13
3 years, 11 months ago (2017-01-14 23:58:58 UTC) #6
Dirk Pranke
3 years, 11 months ago (2017-01-15 01:16:11 UTC) #7
Message was sent while issue was closed.
On 2017/01/14 23:58:58, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/2592262cc9dc8ea6cbe00a69a9b2...

This should address crbug.com/681161 and crbug.com/680268, hopefully.

Powered by Google App Engine
This is Rietveld 408576698