Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2635553003: Fix testHistoryForwardNavigation. (Closed)

Created:
3 years, 11 months ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix testHistoryForwardNavigation. This CL first checks for webview sentinel text to be displayed before checking the omnibox contents. Since the web view text matcher executes JavaScript on the page to search for the sentinel text, this prevents the omnibox text check from occurring until the page has been loaded and the script is executed. BUG=677129 Review-Url: https://codereview.chromium.org/2635553003 Cr-Commit-Position: refs/heads/master@{#443738} Committed: https://chromium.googlesource.com/chromium/src/+/6a288792818793041b5f5eb3e540c43f17f3b094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M ios/chrome/browser/web/navigation_egtest.mm View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kkhorimoto
3 years, 11 months ago (2017-01-13 23:43:04 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-13 23:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635553003/1
3 years, 11 months ago (2017-01-13 23:51:19 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 00:11:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a288792818793041b5f5eb3e540...

Powered by Google App Engine
This is Rietveld 408576698