[GeometryInterface] add toJSON() function in DOMQuad

[GeometryInterface] add toJSON() function in DOMQuad

Return the result of jsonObject which has all attributes.

spec list:
https://drafts.fxtf.org/geometry/#domquad

BUG=678237
Review-Url: https://codereview.chromium.org/2635543003
Cr-Commit-Position: refs/heads/master@{#444345}
Committed: https://chromium.googlesource.com/chromium/src/+/35ae2da872692c4a5c9570dd5d70f1a13ac7f754

[Hwanseung Lee, 2017-01-14 05:36:08]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 05:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-01-14 07:05:16]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2017-01-14 07:05:17]

@dominicc, zino
PTAL, thank you.

[commit-bot: I haz the power, 2017-01-14 07:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 07:09:59]

Dry run: This issue passed the CQ dry run.

[zino, 2017-01-15 04:34:36]

lgtm

[zino, 2017-01-15 04:35:10]

Please update your CL description. (toJson() -> toJSON())

[Hwanseung Lee, 2017-01-16 10:04:35]

Description was changed from

==========
[GeometryInterface] add toJson() function in DOMQuad

Return the result of jsonObject which has all attributes.

spec list:
https://drafts.fxtf.org/geometry/#domquad

BUG=678237
==========

to

==========
[GeometryInterface] add toJSON() function in DOMQuad

Return the result of jsonObject which has all attributes.

spec list:
https://drafts.fxtf.org/geometry/#domquad

BUG=678237
==========

[Hwanseung Lee, 2017-01-16 10:04:56]

On 2017/01/15 04:35:10, zino wrote:
> Please update your CL description. (toJson() -> toJSON())

i fixed it. thanks.

[dominicc (has gone to gerrit), 2017-01-18 01:48:42]

lgtm

LGTM modulo a couple of formatting nits inline.

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html
(right):

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html:23: var
quad =  new DOMQuad(p1, p2, p3, p4);
Delete the extra space after =

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html:24:
assert_dom_point_equals(quad.toJSON().p1, p1 , "p1");
Delete the extra space before , "p1

[Hwanseung Lee, 2017-01-18 12:04:28]

@dominicc

i fixed it, thank you.

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html
(right):

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html:23: var
quad =  new DOMQuad(p1, p2, p3, p4);
On 2017/01/18 01:48:42, dominicc wrote:
> Delete the extra space after =

Done.

https://codereview.chromium.org/2635543003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html:24:
assert_dom_point_equals(quad.toJSON().p1, p1 , "p1");
On 2017/01/18 01:48:42, dominicc wrote:
> Delete the extra space before , "p1

Done.

[Hwanseung Lee, 2017-01-18 12:04:33]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-01-18 12:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
jinho.bang@samsung.com, dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2635543003/#ps20001
(title: "[GeometryInterface] add toJson() function in DOMQuad")

[commit-bot: I haz the power, 2017-01-18 12:04:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 13:49:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484741073593200,
"parent_rev": "db5f41b6556a48763020ac929f901a507682cf04", "commit_rev":
"35ae2da872692c4a5c9570dd5d70f1a13ac7f754"}

[commit-bot: I haz the power, 2017-01-18 13:50:17]

Description was changed from

==========
[GeometryInterface] add toJSON() function in DOMQuad

Return the result of jsonObject which has all attributes.

spec list:
https://drafts.fxtf.org/geometry/#domquad

BUG=678237
==========

to

==========
[GeometryInterface] add toJSON() function in DOMQuad

Return the result of jsonObject which has all attributes.

spec list:
https://drafts.fxtf.org/geometry/#domquad

BUG=678237

Review-Url: https://codereview.chromium.org/2635543003
Cr-Commit-Position: refs/heads/master@{#444345}
Committed:
https://chromium.googlesource.com/chromium/src/+/35ae2da872692c4a5c9570dd5d70...
==========

[commit-bot: I haz the power, 2017-01-18 13:50:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/35ae2da872692c4a5c9570dd5d70...