net: fix multiple use-after-scope issues in net_unittests.

net: fix multiple use-after-scope issues in net_unittests.

Most of the issues are due to the fact that Transaction destructor
accesses the request reference that is stack allocated and has
a shorter lifespan, which causes an invalid access to a potentially
reused memory.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
Review-Url: https://codereview.chromium.org/2635533002
Cr-Commit-Position: refs/heads/master@{#443685}
Committed: https://chromium.googlesource.com/chromium/src/+/0bfeb6b121c5cfd7658c485dcf2077826bad2f2b

[krasin1, 2017-01-13 19:46:16]

krasin@chromium.org changed reviewers:
+ agl@chromium.org

[krasin1, 2017-01-13 19:50:07]

krasin@chromium.org changed reviewers:
+ mmenke@chromium.org
- agl@chromium.org

[mmenke, 2017-01-13 20:04:39]

LGTM!

Just for future reference, if you add someone after you publish your first
comment, you should post a message to make sure people know they're the one's
you want to review, rather than that you're just modifying a file they have on a
watchlist.  Otherwise, they could miss the review email.

[krasin1, 2017-01-13 21:14:01]

On 2017/01/13 20:04:39, mmenke wrote:
> LGTM!
> 
> Just for future reference, if you add someone after you publish your first
> comment, you should post a message to make sure people know they're the one's
> you want to review, rather than that you're just modifying a file they have on
a
> watchlist.  Otherwise, they could miss the review email.

Thank you. I will do that next time.

[krasin1, 2017-01-13 21:14:07]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:14:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:48:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484342047043980, "parent_rev":
"4f24093ff9c2a18dcddb8728edf40be941b8aadc", "commit_rev":
"0bfeb6b121c5cfd7658c485dcf2077826bad2f2b"}

[commit-bot: I haz the power, 2017-01-13 21:49:06]

Description was changed from

==========
net: fix multiple use-after-scope issues in net_unittests.

Most of the issues are due to the fact that Transaction destructor
accesses the request reference that is stack allocated and has
a shorter lifespan, which causes an invalid access to a potentially
reused memory.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
==========

to

==========
net: fix multiple use-after-scope issues in net_unittests.

Most of the issues are due to the fact that Transaction destructor
accesses the request reference that is stack allocated and has
a shorter lifespan, which causes an invalid access to a potentially
reused memory.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897

Review-Url: https://codereview.chromium.org/2635533002
Cr-Commit-Position: refs/heads/master@{#443685}
Committed:
https://chromium.googlesource.com/chromium/src/+/0bfeb6b121c5cfd7658c485dcf20...
==========

[commit-bot: I haz the power, 2017-01-13 21:49:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0bfeb6b121c5cfd7658c485dcf20...