Make sure we correctly dispatch custom events having the same names as unprefixed animations events

Make sure we correctly dispatch custom events having the same names as unprefixed animations events

If support for unprefixed animations is disabled and a custom event happens
to have the same type name then we should dispatch them no matter.

As inside blink we dispatch unprefixed events (no matter if the support is on
or off), we had a piece of code which was retargeting the name to unprefixed when
the support was off. This was not working in the case of custom events as they were
being retargeted to prefixed. I'm glad we can get rid of this condition when the
support of unprefixed animations ships.

I've added a set of tests in the stable/ directory to specifically covers the fact
that the unprefixed animations support is off. These two tests can be removed when
unprefixed animations are default. The other tests in the regular animations/ directory
are for regression testing.

BUG=367537
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173024

[Julien - ping for review, 2014-04-30 18:53:07]

not-really-happy lgtm but the other alternatives are worse and need to be merged
this back to M35 and M34 (it's breaking some sites).

We should just flip the unprefix switch on M36 which would kill the need for
this hack.

https://codereview.chromium.org/263553010/diff/1/Source/core/events/EventTarg...
File Source/core/events/EventTarget.cpp (right):

https://codereview.chromium.org/263553010/diff/1/Source/core/events/EventTarg...
Source/core/events/EventTarget.cpp:270: || event->type() ==
EventTypeNames::animationstart) && event->interfaceName() !=
EventNames::CustomEvent)
I would like a comment that this is a hack and only meant to fix a special case,
we should not extend it to other events (pointing web-authors to that) and
instead just flip the flag for real.

[darktears, 2014-04-30 19:06:23]

On 2014/04/30 18:53:07, Julien Chaffraix - PST wrote:
> not-really-happy lgtm but the other alternatives are worse and need to be
merged
> this back to M35 and M34 (it's breaking some sites).

I'm not really happy either :D.

> 
> We should just flip the unprefix switch on M36 which would kill the need for
> this hack.
> 

Yes. I agree. Now that transform is set to ship unprefixed, we can also ship
animations unprefixed. dstockwell what do you think?

>
https://codereview.chromium.org/263553010/diff/1/Source/core/events/EventTarg...
> File Source/core/events/EventTarget.cpp (right):
> 
>
https://codereview.chromium.org/263553010/diff/1/Source/core/events/EventTarg...
> Source/core/events/EventTarget.cpp:270: || event->type() ==
> EventTypeNames::animationstart) && event->interfaceName() !=
> EventNames::CustomEvent)
> I would like a comment that this is a hack and only meant to fix a special
case,
> we should not extend it to other events (pointing web-authors to that) and
> instead just flip the flag for real.

Added in the last patchset.

Someone to help me to merge this back to 34 and 35 when it lands?

[darktears, 2014-04-30 20:04:13]

The CQ bit was checked by alexis.menard@intel.com

[commit-bot: I haz the power, 2014-04-30 20:04:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexis.menard@intel.com/263553010/20001

[commit-bot: I haz the power, 2014-04-30 20:34:40]

Change committed as 173024