Source/core/events/EventTarget.cpp - Issue 263553010: Make sure we correctly dispatch custom events having the same names as unprefixed animations events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/EventTarget.cpp

Issue 263553010: Make sure we correctly dispatch custom events having the same names as unprefixed animations events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/virtual/stable/animations-unprefixed/animation-events-unprefixed-04-expected.txt ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/events/EventTarget.cpp

diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp

index 8cc27463a0873ccad916847db2874518a9511632..7110ca1cf8e93fb2b675d869f45559d60afbeb6c 100644

--- a/Source/core/events/EventTarget.cpp

+++ b/Source/core/events/EventTarget.cpp

@@ -267,7 +267,11 @@ bool EventTarget::fireEventListeners(Event* event)

EventListenerVector* listenersVector = d->eventListenerMap.find(event->type());

if (!RuntimeEnabledFeatures::cssAnimationUnprefixedEnabled() && (event->type() == EventTypeNames::animationiteration || event->type() == EventTypeNames::animationend

- || event->type() == EventTypeNames::animationstart))

+ || event->type() == EventTypeNames::animationstart)

+ // Some code out-there uses custom events to dispatch unprefixed animation events manually,

+ // we can safely remove all this block when cssAnimationUnprefixedEnabled is always on, this

+ // is really a special case. DO NOT ADD MORE EVENTS HERE.

+ && event->interfaceName() != EventNames::CustomEvent)

listenersVector = 0;

if (listenersVector) {