Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 26355002: Disable offsetWidth optimization in perparation for disabling it on M30. (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Disable offsetWidth optimization in perparation for disabling it on M30. Unfortunately our offsetWidth optimization which made economist.com 2s faster isn't quite correct. It caused a bad regression on M30, which was noticed in the Beta channel. The code has differed some from the Beta branch, but in an effort to be as safe as can be, I'm making a very-similar change on Trunk to the change I'm about to roll into M30. We will need to fix this optimization and re-enable it once it's safe in order to get our 2s back on economist.com. I expect this to slow down some benchmarks. R=abarth@chromium.org, abarth, enne, tonyg BUG=290399 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159046

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/rendering/RenderBox.cpp View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
LGTM. It might be good to touch base with tonyg so that he's not surprised ...
7 years, 2 months ago (2013-10-07 21:17:47 UTC) #1
eseidel
7 years, 2 months ago (2013-10-07 21:18:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r159046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698