Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 26355002: Disable offsetWidth optimization in perparation for disabling it on M30. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index 84f11e672d2eb3c9686e9e5df2477c6fd974017a..0474d3bf906d94137232fa4511d291a8440de582 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -410,7 +410,12 @@ int RenderBox::pixelSnappedOffsetHeight() const
bool RenderBox::canDetermineWidthWithoutLayout() const
{
- // THIS OPTIMIZATION IS INCORRECT AS WRITTEN.
+ // FIXME: This optimization is incorrect as written.
+ // We need to be able to opt-in to this behavior only when
+ // it's guarentted correct.
abarth-chromium 2013/10/07 21:17:47 typo: guarentted
+ // Until then disabling this optimization to be safe.
+ return false;
+
// FIXME: There are likely many subclasses of RenderBlockFlow which
// cannot determine their layout just from style!
// Perhaps we should create a "PlainRenderBlockFlow"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698