Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2635493004: ChromeOS OOBE: update MD-OOBE after UI review. (Closed)

Created:
3 years, 11 months ago by Alexander Alekseev
Modified:
3 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, dcheng, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: update MD-OOBE after UI review. This CL updates styles for ChromeOS OOBE screens after UI review. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2635493004 Cr-Commit-Position: refs/heads/master@{#443966} Committed: https://chromium.googlesource.com/chromium/src/+/571fb9dccbf8f0d39f708a7639eef95e9bd7f1ac

Patch Set 1 #

Patch Set 2 : Added oobe-shield. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_a11y_option.css View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog.css View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_eula.css View 2 chunks +2 lines, -6 lines 2 comments Download
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_container.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/screen_container.css View 1 2 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 21 (14 generated)
Alexander Alekseev
Please review.
3 years, 11 months ago (2017-01-13 23:23:13 UTC) #3
achuithb
On 2017/01/13 23:23:13, Alexander Alekseev wrote: > Please review. I can lg this, but tbh, ...
3 years, 11 months ago (2017-01-13 23:38:30 UTC) #6
Alexander Alekseev
-achuith +michaelpg Please review.
3 years, 11 months ago (2017-01-13 23:49:32 UTC) #8
michaelpg
lgtm https://codereview.chromium.org/2635493004/diff/20001/chrome/browser/resources/chromeos/login/oobe_eula.css File chrome/browser/resources/chromeos/login/oobe_eula.css (right): https://codereview.chromium.org/2635493004/diff/20001/chrome/browser/resources/chromeos/login/oobe_eula.css#newcode27 chrome/browser/resources/chromeos/login/oobe_eula.css:27: --paper-checkbox-checked-color: rgb(66, 133, 244); /* #4285f4 */ nit: ...
3 years, 11 months ago (2017-01-16 17:57:47 UTC) #15
Alexander Alekseev
https://codereview.chromium.org/2635493004/diff/20001/chrome/browser/resources/chromeos/login/oobe_eula.css File chrome/browser/resources/chromeos/login/oobe_eula.css (right): https://codereview.chromium.org/2635493004/diff/20001/chrome/browser/resources/chromeos/login/oobe_eula.css#newcode27 chrome/browser/resources/chromeos/login/oobe_eula.css:27: --paper-checkbox-checked-color: rgb(66, 133, 244); /* #4285f4 */ On 2017/01/16 ...
3 years, 11 months ago (2017-01-17 00:39:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635493004/20001
3 years, 11 months ago (2017-01-17 00:39:38 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 01:33:59 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/571fb9dccbf8f0d39f708a7639ee...

Powered by Google App Engine
This is Rietveld 408576698