Suppress browser microdump when renderer crashes in multiprocess WebView.

Suppress browser microdump when renderer crashes in multiprocess WebView.

Currently when WebView is in multiprocess mode and the renderer crashes,
browser code detects the crash and terminates the application in order
to provide compatibility with single process behaviour (where a renderer
crash would implicitly also be an application crash). We need the browser
(= application process) to die in a way that triggers debuggerd, but we
don't want the browser microdump (it's not informative). For this reason,
we suppress the generation of the microdump at the point we terminate
the application.

The renderer process crash dialog is already suppressed on user builds,
by virtue of not re-raising the signal.

BUG=642344
Review-Url: https://codereview.chromium.org/2635493002
Cr-Commit-Position: refs/heads/master@{#444131}
Committed: https://chromium.googlesource.com/chromium/src/+/fa882b53462e83fd7a2470f375ee322f7c9c8914

[Tobias Sargeant, 2017-01-13 15:31:20]

tobiasjs@chromium.org changed reviewers:
+ rsesek@chromium.org, sgurun@chromium.org, torne@chromium.org

[Tobias Sargeant, 2017-01-13 16:23:14]

Description was changed from

==========
Suppress browser microdump when renderer crashes in multiprocess WebView.

Currently when WebView is in multiprocess mode and the renderer crashes,
browser code detects the crash and terminates the application in order
to provide compatibility with single process behaviour (where a renderer
crash would implicitly also be an application crash). We need the browser
(= application process) to die in a way that triggers debuggerd, but we
don't want the browser microdump (it's not informative). For this reason,
we suppress the generation of the microdump at the point we terminate
the application.

This doesn't directly solve the problem of debuggerd showing two crash
dialogs (except that this only happens on debug images); doing so
will require exiting the renderer process in a way that didn't trigger
debuggerd.

BUG=
==========

to

==========
Suppress browser microdump when renderer crashes in multiprocess WebView.

Currently when WebView is in multiprocess mode and the renderer crashes,
browser code detects the crash and terminates the application in order
to provide compatibility with single process behaviour (where a renderer
crash would implicitly also be an application crash). We need the browser
(= application process) to die in a way that triggers debuggerd, but we
don't want the browser microdump (it's not informative). For this reason,
we suppress the generation of the microdump at the point we terminate
the application.

The renderer process crash dialog is already suppressed on user builds,
by virtue of not re-raising the signal.

BUG=642344
==========

[sgurun-gerrit only, 2017-01-13 18:18:58]

On 2017/01/13 15:31:20, Tobias Sargeant wrote:

aw lgtm
did not look at components pieces.

[Torne, 2017-01-16 12:08:57]

LGTM in general but I think this won't compile on non-android:

https://codereview.chromium.org/2635493002/diff/20001/components/crash/conten...
File components/crash/content/app/breakpad_linux.cc (right):

https://codereview.chromium.org/2635493002/diff/20001/components/crash/conten...
components/crash/content/app/breakpad_linux.cc:779: ShouldGenerateDump,
Does this need to be #if defined(OS_ANDROID)? The definition of the function
above is..

[Tobias Sargeant, 2017-01-16 14:01:37]

https://codereview.chromium.org/2635493002/diff/20001/components/crash/conten...
File components/crash/content/app/breakpad_linux.cc (right):

https://codereview.chromium.org/2635493002/diff/20001/components/crash/conten...
components/crash/content/app/breakpad_linux.cc:779: ShouldGenerateDump,
On 2017/01/16 12:08:57, Torne wrote:
> Does this need to be #if defined(OS_ANDROID)? The definition of the function
> above is..

It certainly should be. Thanks.

[Tobias Sargeant, 2017-01-16 14:01:57]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 14:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 14:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 14:19:23]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Tobias Sargeant, 2017-01-16 14:31:18]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 14:31:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 14:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 14:47:32]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Tobias Sargeant, 2017-01-16 14:59:39]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 14:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 15:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 15:38:10]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-01-17 19:21:48]

lgtm

[Tobias Sargeant, 2017-01-17 19:58:26]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2017-01-17 19:58:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2635493002/#ps80001
(title: "reorder functions. again.")

[commit-bot: I haz the power, 2017-01-17 19:59:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 20:42:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484683106398620,
"parent_rev": "cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461", "commit_rev":
"fa882b53462e83fd7a2470f375ee322f7c9c8914"}

[commit-bot: I haz the power, 2017-01-17 20:43:16]

Description was changed from

==========
Suppress browser microdump when renderer crashes in multiprocess WebView.

Currently when WebView is in multiprocess mode and the renderer crashes,
browser code detects the crash and terminates the application in order
to provide compatibility with single process behaviour (where a renderer
crash would implicitly also be an application crash). We need the browser
(= application process) to die in a way that triggers debuggerd, but we
don't want the browser microdump (it's not informative). For this reason,
we suppress the generation of the microdump at the point we terminate
the application.

The renderer process crash dialog is already suppressed on user builds,
by virtue of not re-raising the signal.

BUG=642344
==========

to

==========
Suppress browser microdump when renderer crashes in multiprocess WebView.

Currently when WebView is in multiprocess mode and the renderer crashes,
browser code detects the crash and terminates the application in order
to provide compatibility with single process behaviour (where a renderer
crash would implicitly also be an application crash). We need the browser
(= application process) to die in a way that triggers debuggerd, but we
don't want the browser microdump (it's not informative). For this reason,
we suppress the generation of the microdump at the point we terminate
the application.

The renderer process crash dialog is already suppressed on user builds,
by virtue of not re-raising the signal.

BUG=642344

Review-Url: https://codereview.chromium.org/2635493002
Cr-Commit-Position: refs/heads/master@{#444131}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa882b53462e83fd7a2470f375ee...
==========

[commit-bot: I haz the power, 2017-01-17 20:43:17]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fa882b53462e83fd7a2470f375ee...