bluetooth: web: web_bluetooth.mojom comments and UUID type fix.

bluetooth: web: web_bluetooth.mojom comments and UUID type fix.

In https://codereview.chromium.org/2466223002 dcheng requested
improved comments in the web_bluetooth.mojom file. 

This change:
+ References where to understand Bluetooth GATT terms.
+ Describes the use of instance IDs and UUIDs.
+ Clarifies how attribute retrieval is done.
+ Upgrades all use of UUIDs to be of type 'bluetooth.mojom.UUID'.

BUG=680587
Review-Url: https://codereview.chromium.org/2635473004
Cr-Commit-Position: refs/heads/master@{#444200}
Committed: https://chromium.googlesource.com/chromium/src/+/69022eccc884e5541518c448e965f79f8aa17f95

[scheib, 2017-01-14 05:28:03]

scheib@chromium.org changed reviewers:
+ dcheng@chromium.org

[scheib, 2017-01-14 05:28:13]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 05:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 07:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 07:15:02]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-14 10:23:46]

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
(right):

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:13: //
to refer to previously disclosed objects.
Nit: Perhaps expand GATT the first time it's written (Generic ATTribute is my
assumption for what it stands for, based on my searching).

For people who aren't familiar with Bluetooth, it might be nice to explain other
terminology or provide a pointer to a resource that does: I don't really know
what a characteristic or descriptor is, for example, and I assume that devices
can provide services, but I have no clue =)

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:131:
string uuid;
Why does this need both uuid and instance_id? Also, what's the difference
between string uuid and bluetooth.mojom.UUID?

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:235: //
that do this will be notified of device events e.g. device disconnection.
Btw, is it expected this will be a 1:1 sort of relationship? i.e. is something
that connects to the bluetooth service expected to provide this client?

[scheib, 2017-01-17 19:19:41]

Description was changed from

==========
bluetooth: web: web_bluetooth.mojom comments, IDs and attribute retrieval.

In https://codereview.chromium.org/2466223002 dcheng requested
improved comments in the web_bluetooth.mojom file. This change
describes the use of IDs, and clarifies how attribute
retrieval is done.

BUG=680587
==========

to

==========
bluetooth: web: web_bluetooth.mojom comments and UUID type fix.

In https://codereview.chromium.org/2466223002 dcheng requested
improved comments in the web_bluetooth.mojom file. 

This change:
+ References where to understand Bluetooth GATT terms.
+ Describes the use of instance IDs and UUIDs.
+ Clarifies how attribute retrieval is done.
+ Upgrades all use of UUIDs to be of type 'bluetooth.mojom.UUID'.

BUG=680587
==========

[scheib, 2017-01-17 19:20:26]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[scheib, 2017-01-17 19:20:43]

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
(right):

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:13: //
to refer to previously disclosed objects.
On 2017/01/14 10:23:45, dcheng wrote:
> Nit: Perhaps expand GATT the first time it's written (Generic ATTribute is my
> assumption for what it stands for, based on my searching).
> 
> For people who aren't familiar with Bluetooth, it might be nice to explain
other
> terminology or provide a pointer to a resource that does: I don't really know
> what a characteristic or descriptor is, for example, and I assume that devices
> can provide services, but I have no clue =)

Done.

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:131:
string uuid;
On 2017/01/14 10:23:45, dcheng wrote:
> Why does this need both uuid and instance_id? 

I added comments.

> Also, what's the difference
> between string uuid and bluetooth.mojom.UUID?

I changed the types to use the new bluetooth.mojom.UUID.

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:235: //
that do this will be notified of device events e.g. device disconnection.
On 2017/01/14 10:23:45, dcheng wrote:
> Btw, is it expected this will be a 1:1 sort of relationship? i.e. is something
> that connects to the bluetooth service expected to provide this client?

1:1,

WebBluetoothServiceClient is only used in interface WebBluetoothService
SetClient which comments that "Sets the client for this WebBluetoothService."

[commit-bot: I haz the power, 2017-01-17 19:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 21:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:04:19]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-17 23:39:15]

LGTM

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
(right):

https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:235: //
that do this will be notified of device events e.g. device disconnection.
On 2017/01/17 19:20:43, scheib wrote:
> On 2017/01/14 10:23:45, dcheng wrote:
> > Btw, is it expected this will be a 1:1 sort of relationship? i.e. is
something
> > that connects to the bluetooth service expected to provide this client?
> 
> 1:1,
> 
> WebBluetoothServiceClient is only used in interface WebBluetoothService
> SetClient which comments that "Sets the client for this WebBluetoothService." 

If it's always 1:1, would you be willing to file a bug/explore making sure this
invariant always hold? The current way to do that is using a factory interface,
though Mojo may explore alternatives if there's enough demand (see
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/j-kiK17V-Qc)

[scheib, 2017-01-18 00:10:10]

On 2017/01/17 23:39:15, dcheng wrote:
> LGTM
> 
>
https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
> (right):
> 
>
https://codereview.chromium.org/2635473004/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom:235:
//
> that do this will be notified of device events e.g. device disconnection.
> On 2017/01/17 19:20:43, scheib wrote:
> > On 2017/01/14 10:23:45, dcheng wrote:
> > > Btw, is it expected this will be a 1:1 sort of relationship? i.e. is
> something
> > > that connects to the bluetooth service expected to provide this client?
> > 
> > 1:1,
> > 
> > WebBluetoothServiceClient is only used in interface WebBluetoothService
> > SetClient which comments that "Sets the client for this
WebBluetoothService." 
> 
> If it's always 1:1, would you be willing to file a bug/explore making sure
this
> invariant always hold? The current way to do that is using a factory
interface,
> though Mojo may explore alternatives if there's enough demand (see
>
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/j-kiK17V-Qc)

Issue filed, blocking current onion souping work.
https://bugs.chromium.org/p/chromium/issues/detail?id=682050

[scheib, 2017-01-18 00:10:17]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:19:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484698217386900,
"parent_rev": "d1f880de459aec1ee63f170addd7fd3e18cf85fd", "commit_rev":
"69022eccc884e5541518c448e965f79f8aa17f95"}

[commit-bot: I haz the power, 2017-01-18 00:20:21]

Description was changed from

==========
bluetooth: web: web_bluetooth.mojom comments and UUID type fix.

In https://codereview.chromium.org/2466223002 dcheng requested
improved comments in the web_bluetooth.mojom file. 

This change:
+ References where to understand Bluetooth GATT terms.
+ Describes the use of instance IDs and UUIDs.
+ Clarifies how attribute retrieval is done.
+ Upgrades all use of UUIDs to be of type 'bluetooth.mojom.UUID'.

BUG=680587
==========

to

==========
bluetooth: web: web_bluetooth.mojom comments and UUID type fix.

In https://codereview.chromium.org/2466223002 dcheng requested
improved comments in the web_bluetooth.mojom file. 

This change:
+ References where to understand Bluetooth GATT terms.
+ Describes the use of instance IDs and UUIDs.
+ Clarifies how attribute retrieval is done.
+ Upgrades all use of UUIDs to be of type 'bluetooth.mojom.UUID'.

BUG=680587

Review-Url: https://codereview.chromium.org/2635473004
Cr-Commit-Position: refs/heads/master@{#444200}
Committed:
https://chromium.googlesource.com/chromium/src/+/69022eccc884e5541518c448e965...
==========

[commit-bot: I haz the power, 2017-01-18 00:20:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69022eccc884e5541518c448e965...