Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2635443002: [Reland][Extensions] Enable sideloading prompt on mac on canary (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland][Extensions] Enable sideloading prompt on mac on canary Reverted due to compile error; now fixed. BUG=669277 Review-Url: https://codereview.chromium.org/2635443002 Cr-Commit-Position: refs/heads/master@{#443576} Committed: https://chromium.googlesource.com/chromium/src/+/9d7ae4d5ebc6a01a9c443d91c86f788ae2815ddc

Patch Set 1 : original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_install_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/external_install_manager.cc View 1 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
lazyboy@, mind taking a look?
3 years, 11 months ago (2017-01-13 02:48:00 UTC) #4
lazyboy
lgtm
3 years, 11 months ago (2017-01-13 03:04:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635443002/20001
3 years, 11 months ago (2017-01-13 16:03:01 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:38:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d7ae4d5ebc6a01a9c443d91c86f...

Powered by Google App Engine
This is Rietveld 408576698