Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2635423002: Enable HTTP-bad Phase 1 by default except iOS (Closed)

Created:
3 years, 11 months ago by estark
Modified:
3 years, 11 months ago
Reviewers:
lgarron
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HTTP-bad Phase 1 by default except iOS This feature is launching in Chrome 56 on all platforms except iOS. BUG=657143 Review-Url: https://codereview.chromium.org/2635423002 Cr-Commit-Position: refs/heads/master@{#444945} Committed: https://chromium.googlesource.com/chromium/src/+/bcfa0007f638e46826cf0803746dfd90c53d6fc4

Patch Set 1 #

Patch Set 2 : oops don't accidentally launch the wrong feature #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -52 lines) Patch
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download
M components/security_state/core/security_state.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M components/security_state/core/security_state_unittest.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
estark
lgarron: take 2, this time just enabling the feature by default on non-iOS
3 years, 11 months ago (2017-01-18 02:24:04 UTC) #4
estark
On 2017/01/18 02:24:04, estark wrote: > lgarron: take 2, this time just enabling the feature ...
3 years, 11 months ago (2017-01-19 05:38:33 UTC) #15
lgarron
LGTM for the code change. Why remove the tests? Because you'd have to change them ...
3 years, 11 months ago (2017-01-19 22:05:53 UTC) #16
estark
On 2017/01/19 22:05:53, lgarron wrote: > LGTM for the code change. > > Why remove ...
3 years, 11 months ago (2017-01-19 22:07:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635423002/40001
3 years, 11 months ago (2017-01-19 22:16:17 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/372416)
3 years, 11 months ago (2017-01-19 23:15:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635423002/40001
3 years, 11 months ago (2017-01-19 23:38:13 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 02:00:18 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bcfa0007f638e46826cf0803746d...

Powered by Google App Engine
This is Rietveld 408576698