Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2635353002: [builtins] introduce AsyncBuiltinsAssembler for ES2016 features and beyond (Closed)

Created:
3 years, 11 months ago by caitp
Modified:
3 years, 11 months ago
Reviewers:
gsathya, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] introduce AsyncBuiltinsAssembler for ES2016 features and beyond First step in splitting apart https://codereview.chromium.org/2622833002/ to land piece by piece. Porting src/js/async-await.js to TF builtins using this boilerplate is now very straightforward. BUG=v8:4483, v8:5855 R=jgruber@chromium.org, gsathya@chromium.org Review-Url: https://codereview.chromium.org/2635353002 Cr-Commit-Position: refs/heads/master@{#42466} Committed: https://chromium.googlesource.com/v8/v8/+/4173fda417a38765d4fd72454959bc953b0062c8

Patch Set 1 #

Patch Set 2 : remove include from test-code-stub-assembler.cc #

Patch Set 3 : add some comments to make it easier to read the code #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/builtins/builtins-async.h View 1 chunk +35 lines, -0 lines 0 comments Download
A src/builtins/builtins-async.cc View 1 2 1 chunk +93 lines, -0 lines 1 comment Download
M src/builtins/builtins-promise.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caitp
I believe this is all the boilerplate needed for implementing async-await.js in TF. AsyncBuiltinsAssembler::Await() is ...
3 years, 11 months ago (2017-01-17 22:25:41 UTC) #3
jgruber
lgtm
3 years, 11 months ago (2017-01-18 11:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635353002/40001
3 years, 11 months ago (2017-01-18 15:12:21 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/4173fda417a38765d4fd72454959bc953b0062c8
3 years, 11 months ago (2017-01-18 15:41:07 UTC) #9
jgruber
3 years, 11 months ago (2017-01-20 08:17:19 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2635353002/diff/40001/src/builtins/builtins-a...
File src/builtins/builtins-async.cc (right):

https://codereview.chromium.org/2635353002/diff/40001/src/builtins/builtins-a...
src/builtins/builtins-async.cc:64: CallRuntime(Runtime::kSetProperty, on_reject,
key, TrueConstant(),
Just noticed that context is missing here as the second parameter (below as
well). Fixing in https://codereview.chromium.org/2643023002/.

Powered by Google App Engine
This is Rietveld 408576698