Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 2635313002: [CacheStorage] Disabled cached size DCHECK. (Closed)

Created:
3 years, 11 months ago by cmumford
Modified:
3 years, 11 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, nhiroki
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Disabled cached size DCHECK. The cache size, saved in the index file, was getting out-of-sync with the actual cache size. A speculative fix was landed in crrev.com/2613183003 but even if this fixed the problem, this DCHECK would still fail with no obvious resolution. Disabling this DCHECK - at least temporarily. BUG=681900 Review-Url: https://codereview.chromium.org/2635313002 Cr-Commit-Position: refs/heads/master@{#444122} Committed: https://chromium.googlesource.com/chromium/src/+/9964f41926c6d9d18a9fbf338d4f8acb3d1825a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/cache_storage/cache_storage_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
cmumford
3 years, 11 months ago (2017-01-17 19:06:41 UTC) #2
jkarlin
lgtm while we figure out what the problem is. Glad you had the dcheck to ...
3 years, 11 months ago (2017-01-17 19:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635313002/1
3 years, 11 months ago (2017-01-17 19:28:30 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 20:27:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9964f41926c6d9d18a9fbf338d4f...

Powered by Google App Engine
This is Rietveld 408576698