Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2635293002: Ensure navigator.getVRDisplays always resolves. (Closed)

Created:
3 years, 11 months ago by bajones
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Ensure navigator.getVRDisplays always resolves. Second attempt at landing. See https://codereview.chromium.org/2614873002/ In the case that the backing VR service is not available the call will now resolve to an empty array. BUG=678283 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=rockot@chromium.org, alexmos@chromium.org Review-Url: https://codereview.chromium.org/2630003002 Cr-Commit-Position: refs/heads/master@{#443791} (cherry picked from commit a74a47aec12401d3ea3643aea1d8b66d908c32cc) Review-Url: https://codereview.chromium.org/2635293002 . Cr-Commit-Position: refs/branch-heads/2924@{#780} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/b963393a689eccefe4d9a72c58fca36c05056c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +9 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRController.cpp View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bajones
3 years, 11 months ago (2017-01-17 18:21:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b963393a689eccefe4d9a72c58fca36c05056c18.

Powered by Google App Engine
This is Rietveld 408576698