Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2635243002: [turbofan] Refactor IsSame into NodeProperties. (Closed)

Created:
3 years, 11 months ago by epertoso
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refactor IsSame into NodeProperties. BUG= Review-Url: https://codereview.chromium.org/2635243002 Cr-Commit-Position: refs/heads/master@{#42439} Committed: https://chromium.googlesource.com/v8/v8/+/48eabdcf72576d5184a931906455d4e691c00d6b

Patch Set 1 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -44 lines) Patch
M src/compiler/js-builtin-reducer.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +1 line, -14 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +1 line, -14 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
epertoso
3 years, 11 months ago (2017-01-18 09:14:49 UTC) #8
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-18 09:16:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635243002/20001
3 years, 11 months ago (2017-01-18 09:18:19 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 09:20:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/48eabdcf72576d5184a931906455d4e691c...

Powered by Google App Engine
This is Rietveld 408576698