Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2635223004: Convert AudioBufferSource sample-accurate-scheduling to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioBufferSource sample-accurate-scheduling to testharness Manually convert test to use testharness and new Audit. BUG=676394 TEST=sample-accurate-scheduling.html Review-Url: https://codereview.chromium.org/2635223004 Cr-Commit-Position: refs/heads/master@{#445227} Committed: https://chromium.googlesource.com/chromium/src/+/65eceecf7418a59d7ee03e32f01fbb8dede34bc6

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Address review comments #

Total comments: 4

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -82 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html View 1 2 3 1 chunk +51 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Raymond Toy
PTAL. The new output is: This is a testharness.js-based test. PASS # AUDIT TASK RUNNER ...
3 years, 11 months ago (2017-01-17 17:36:21 UTC) #2
hongchan
https://codereview.chromium.org/2635223004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html (right): https://codereview.chromium.org/2635223004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html#newcode76 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html:76: success = false; Is this |success| used some where?
3 years, 11 months ago (2017-01-18 18:25:15 UTC) #3
Raymond Toy
https://codereview.chromium.org/2635223004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html (right): https://codereview.chromium.org/2635223004/diff/20001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html#newcode76 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html:76: success = false; On 2017/01/18 18:25:15, hongchan (OOO 1.17-1.19) ...
3 years, 11 months ago (2017-01-18 19:21:36 UTC) #4
hongchan
https://codereview.chromium.org/2635223004/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html (right): https://codereview.chromium.org/2635223004/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html#newcode93 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html:93: context = new OfflineAudioContext(2, sampleRate * lengthInSeconds, sampleRate); Wrap ...
3 years, 11 months ago (2017-01-20 18:31:17 UTC) #5
Raymond Toy
https://codereview.chromium.org/2635223004/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html (right): https://codereview.chromium.org/2635223004/diff/40001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html#newcode93 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html:93: context = new OfflineAudioContext(2, sampleRate * lengthInSeconds, sampleRate); On ...
3 years, 11 months ago (2017-01-20 19:37:31 UTC) #6
hongchan
lgtm
3 years, 11 months ago (2017-01-20 23:19:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635223004/60001
3 years, 11 months ago (2017-01-20 23:24:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:33:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/65eceecf7418a59d7ee03e32f01f...

Powered by Google App Engine
This is Rietveld 408576698