Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 2635203002: Quit immediately in TestNavigationObserver. (Closed)
Patch Set: Add comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/ui_test_utils.cc
diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc
index 316f08b2b97ef2874b64f90c25eee90d7cd3ea78..0225cfeb06cdc5a7fb5a7b712705b5d56398ae34 100644
--- a/chrome/test/base/ui_test_utils.cc
+++ b/chrome/test/base/ui_test_utils.cc
@@ -180,8 +180,8 @@ void NavigateToURLWithDispositionBlockUntilNavigationsComplete(
tab_strip->GetActiveWebContents())
content::WaitForLoadStop(tab_strip->GetActiveWebContents());
content::TestNavigationObserver same_tab_observer(
- tab_strip->GetActiveWebContents(),
- number_of_navigations);
+ tab_strip->GetActiveWebContents(), number_of_navigations,
+ content::MessageLoopRunner::QuitMode::DEFERRED);
std::set<Browser*> initial_browsers;
for (auto* browser : *BrowserList::GetInstance())
@@ -221,8 +221,9 @@ void NavigateToURLWithDispositionBlockUntilNavigationsComplete(
same_tab_observer.Wait();
return;
} else if (web_contents) {
- content::TestNavigationObserver observer(web_contents,
- number_of_navigations);
+ content::TestNavigationObserver observer(
+ web_contents, number_of_navigations,
+ content::MessageLoopRunner::QuitMode::DEFERRED);
observer.Wait();
return;
}

Powered by Google App Engine
This is Rietveld 408576698