Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

Issue 2635203002: Quit immediately in TestNavigationObserver. (Closed)
Patch Set: Add comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
index a19949a4beca2f971bade39239ec222a5e4caf6a..974b1e475845a2dac5923e6398d639c593b0516c 100644
--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
@@ -184,8 +184,8 @@ class SBNavigationObserverBrowserTest : public InProcessBrowserTest {
tab_strip->GetActiveWebContents();
ASSERT_TRUE(content::WaitForLoadStop(current_web_contents));
content::TestNavigationObserver navigation_observer(
- current_web_contents,
- number_of_navigations);
+ current_web_contents, number_of_navigations,
+ content::MessageLoopRunner::QuitMode::DEFERRED);
navigation_observer.StartWatchingNewWebContents();
// Execute test.
std::string script = base::StringPrintf("clickLink('%s');", element_id);
« no previous file with comments | « no previous file | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698