Issue 2635193004: Add DCHECK to show that plznav sometimes provides empty global request ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2635193004: Add DCHECK to show that plznav sometimes provides empty global request ids. (Closed)

Created:
3 years, 11 months ago by Bryan McQuade

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add DCHECK to show that plznav sometimes provides empty global request ids. BUG=

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/page_load_metrics/page_load_tracker.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bryan McQuade

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

3 years, 11 months ago (2017-01-18 01:21:21 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635193004/1

3 years, 11 months ago (2017-01-18 01:21:57 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-18 02:54:50 UTC) #3

commit-bot: I haz the power

3 years, 11 months ago (2017-01-18 02:54:50 UTC) #4

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages