Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2635193004: Add DCHECK to show that plznav sometimes provides empty global request ids. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 6f161e9fa3d7913d4eba92157bb0c03939b0b0c4..7312aade22ba6a0ddb84067614611234cae1a38d 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -431,6 +431,7 @@ void PageLoadTracker::WillProcessNavigationResponse(
// PlzNavigate: NavigationHandle::GetGlobalRequestID() sometimes returns an
// uninitialized GlobalRequestID. Bail early in this case. See
// crbug.com/680841 for details.
+ DCHECK(navigation_handle->GetGlobalRequestID() != content::GlobalRequestID());
if (content::IsBrowserSideNavigationEnabled() &&
navigation_handle->GetGlobalRequestID() == content::GlobalRequestID())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698