Ensure same invocation order as creation order for SpellCheckRequests

Ensure same invocation order as creation order for SpellCheckRequests

This patch makes SpellCheckRequester maintain its request queue in
ascending order of sequence, so that request invocation order is always
the same as creation order.

It eases the testing of idle time spell checker.

BUG=681760
Review-Url: https://codereview.chromium.org/2635173002
Cr-Commit-Position: refs/heads/master@{#444283}
Committed: https://chromium.googlesource.com/chromium/src/+/f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b

[Xiaocheng, 2017-01-17 07:45:15]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 07:45:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-17 07:47:09]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-01-17 07:47:09]

PTAL.

[yosin_UTC9, 2017-01-17 08:20:12]

https://codereview.chromium.org/2635173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
(right):

https://codereview.chromium.org/2635173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:230:
for (RequestQueue::const_iterator iter = m_requestQueue.begin();
Can we use std::find_if()?

[Xiaocheng, 2017-01-17 08:46:27]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 08:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-17 08:48:18]

https://codereview.chromium.org/2635173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
(right):

https://codereview.chromium.org/2635173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:230:
for (RequestQueue::const_iterator iter = m_requestQueue.begin();
On 2017/01/17 at 08:20:12, Yosi_UTC9 wrote:
> Can we use std::find_if()?

Yes.Done.

[commit-bot: I haz the power, 2017-01-17 09:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 09:59:49]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-01-18 05:20:33]

Ping...

[yosin_UTC9, 2017-01-18 05:29:19]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-18 05:29:19]

lgtm

[commit-bot: I haz the power, 2017-01-18 05:29:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 05:33:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484717359356820,
"parent_rev": "b141e34157254fd79b5db395386c2129d6418d37", "commit_rev":
"f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b"}

[commit-bot: I haz the power, 2017-01-18 05:34:07]

Description was changed from

==========
Ensure same invocation order as creation order for SpellCheckRequests

This patch makes SpellCheckRequester maintain its request queue in
ascending order of sequence, so that request invocation order is always
the same as creation order.

It eases the testing of idle time spell checker.

BUG=681760
==========

to

==========
Ensure same invocation order as creation order for SpellCheckRequests

This patch makes SpellCheckRequester maintain its request queue in
ascending order of sequence, so that request invocation order is always
the same as creation order.

It eases the testing of idle time spell checker.

BUG=681760

Review-Url: https://codereview.chromium.org/2635173002
Cr-Commit-Position: refs/heads/master@{#444283}
Committed:
https://chromium.googlesource.com/chromium/src/+/f740ee973fc6b34c8788c3e8fb5b...
==========

[commit-bot: I haz the power, 2017-01-18 05:34:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f740ee973fc6b34c8788c3e8fb5b...