Merge list of orthogonal writing mode roots into depth-ordered layout list.

Merge list of orthogonal writing mode roots into depth-ordered layout list.

If we're going to perform a series of subtree layouts, rather than one layout
from LayoutView, and we at the same time have a list of orthogonal writing mode
roots that need to be laid out before their ancestors, we need to make sure
that subtrees are laid out in an overall tree depth ordered manner, or we risk
skipping layout of a subtree needing layout. That would cause trouble for the
column balancer (which examines the tree after layout and expects everything to
be laid out), and quite possibly other kinds of trouble elsewhere too.

BUG=680224
Review-Url: https://codereview.chromium.org/2635143003
Cr-Commit-Position: refs/heads/master@{#445497}
Committed: https://chromium.googlesource.com/chromium/src/+/538d2655968dd8e6a8c3b8baec1b496dd4f74882

[mstensho (USE GERRIT), 2017-01-17 20:55:56]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 20:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:14:32]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2017-01-19 09:55:12]

mstensho@opera.com changed reviewers:
+ kojii@chromium.org

[mstensho (USE GERRIT), 2017-01-23 08:48:53]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[mstensho (USE GERRIT), 2017-01-23 08:48:54]

Please take a look. This fixes a security bug.

[eae, 2017-01-23 18:19:15]

Nice, thank you

LGTM

[eae, 2017-01-23 18:19:19]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 21:45:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485195559834740, "parent_rev":
"0b30ae6989375bfcb3360eea8dfa9a9100ac958b", "commit_rev":
"538d2655968dd8e6a8c3b8baec1b496dd4f74882"}

[commit-bot: I haz the power, 2017-01-23 21:45:41]

Description was changed from

==========
Merge list of orthogonal writing mode roots into depth-ordered layout list.

If we're going to perform a series of subtree layouts, rather than one layout
from LayoutView, and we at the same time have a list of orthogonal writing mode
roots that need to be laid out before their ancestors, we need to make sure
that subtrees are laid out in an overall tree depth ordered manner, or we risk
skipping layout of a subtree needing layout. That would cause trouble for the
column balancer (which examines the tree after layout and expects everything to
be laid out), and quite possibly other kinds of trouble elsewhere too.

BUG=680224
==========

to

==========
Merge list of orthogonal writing mode roots into depth-ordered layout list.

If we're going to perform a series of subtree layouts, rather than one layout
from LayoutView, and we at the same time have a list of orthogonal writing mode
roots that need to be laid out before their ancestors, we need to make sure
that subtrees are laid out in an overall tree depth ordered manner, or we risk
skipping layout of a subtree needing layout. That would cause trouble for the
column balancer (which examines the tree after layout and expects everything to
be laid out), and quite possibly other kinds of trouble elsewhere too.

BUG=680224

Review-Url: https://codereview.chromium.org/2635143003
Cr-Commit-Position: refs/heads/master@{#445497}
Committed:
https://chromium.googlesource.com/chromium/src/+/538d2655968dd8e6a8c3b8baec1b...
==========

[commit-bot: I haz the power, 2017-01-23 21:45:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/538d2655968dd8e6a8c3b8baec1b...

[kojii, 2017-01-24 02:26:48]

lgtm, thank you and sorry that I missed in the first place.