Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2635093003: Remove kAllowed from cronet data reduction proxy code (Closed)

Created:
3 years, 11 months ago by Raj
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kAllowed and kFallbackAllowed from cronet data reduction proxy kAllowed and kFallbackAllowed was removed in this CL. https://codereview.chromium.org/2626963003/ BUG=681872 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2635093003 Cr-Commit-Position: refs/heads/master@{#444510} Committed: https://chromium.googlesource.com/chromium/src/+/3248e3bf783e1a2ff4f7557207ba69696c235dc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M components/cronet/android/cronet_data_reduction_proxy.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Raj
ptal
3 years, 11 months ago (2017-01-17 18:54:42 UTC) #8
Ted C
Adding a couple other potential reviewers...this is breaking the cronet build so it would be ...
3 years, 11 months ago (2017-01-18 21:45:50 UTC) #10
xunjieli
lgtm
3 years, 11 months ago (2017-01-18 21:48:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635093003/1
3 years, 11 months ago (2017-01-18 21:49:55 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:17:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3248e3bf783e1a2ff4f7557207ba...

Powered by Google App Engine
This is Rietveld 408576698