Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 263503003: Add flac into root BUILD.gn (Closed)

Created:
6 years, 7 months ago by awong
Modified:
6 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Add flac into root BUILD.gn All hail GN. oRZ BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268265

Patch Set 1 #

Patch Set 2 : update deps #

Patch Set 3 : fix bad merge #

Patch Set 4 : Get it right this time. #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
awong
6 years, 7 months ago (2014-04-29 21:45:24 UTC) #1
brettw
lgtm
6 years, 7 months ago (2014-04-29 22:06:51 UTC) #2
awong
FYI, add to add a DEPS roll. \o/
6 years, 7 months ago (2014-04-29 22:21:25 UTC) #3
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 7 months ago (2014-04-29 22:22:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/263503003/2
6 years, 7 months ago (2014-04-29 22:24:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 23:00:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 23:00:26 UTC) #7
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 7 months ago (2014-05-02 19:09:58 UTC) #8
awong
The CQ bit was unchecked by ajwong@chromium.org
6 years, 7 months ago (2014-05-02 19:10:00 UTC) #9
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 7 months ago (2014-05-02 19:38:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/263503003/60001
6 years, 7 months ago (2014-05-02 19:38:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:11:30 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:11:31 UTC) #13
awong
The CQ bit was checked by ajwong@chromium.org
6 years, 7 months ago (2014-05-05 18:19:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/263503003/60001
6 years, 7 months ago (2014-05-05 18:21:30 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 20:35:02 UTC) #16
Message was sent while issue was closed. 
Change committed as 268265

Powered by Google App Engine
This is Rietveld 408576698