Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: tracing/tracing/model/heap_dump.html

Issue 2635023002: [tracing] Support new heap dump format (Closed)
Patch Set: remove it again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/heap_dump.html
diff --git a/tracing/tracing/model/heap_dump.html b/tracing/tracing/model/heap_dump.html
index d008e0d44f3e7cb7ff1f9a7b81349d93b955bda5..25172cef7985040e8122207275f8fc4a2a62c17c 100644
--- a/tracing/tracing/model/heap_dump.html
+++ b/tracing/tracing/model/heap_dump.html
@@ -21,7 +21,8 @@ tr.exportTo('tr.model', function() {
*
* @{constructor}
*/
- function HeapEntry(heapDump, leafStackFrame, objectTypeName, size, count) {
+ function HeapEntry(
+ heapDump, leafStackFrame, objectTypeName, size, count, valuesAreSelf) {
fmeawad 2017/03/23 20:43:57 nit: valuesAreSelf is not very descriptive, can yo
this.heapDump = heapDump;
// The leaf stack frame of the associated backtrace (e.g. drawQuad for the
@@ -35,6 +36,7 @@ tr.exportTo('tr.model', function() {
this.size = size;
this.count = count;
+ this.valuesAreSelf = valuesAreSelf;
}
/**
@@ -43,16 +45,19 @@ tr.exportTo('tr.model', function() {
*
* @{constructor}
*/
- function HeapDump(processMemoryDump, allocatorName) {
+ function HeapDump(processMemoryDump, allocatorName, isComplete) {
this.processMemoryDump = processMemoryDump;
this.allocatorName = allocatorName;
+ this.isComplete = isComplete;
this.entries = [];
}
HeapDump.prototype = {
- addEntry: function(leafStackFrame, objectTypeName, size, count) {
+ addEntry: function(
+ leafStackFrame, objectTypeName, size, count, opt_valuesAreSelf) {
+ var valuesAreSelf = opt_valuesAreSelf || false;
var entry = new HeapEntry(
- this, leafStackFrame, objectTypeName, size, count);
+ this, leafStackFrame, objectTypeName, size, count, valuesAreSelf);
this.entries.push(entry);
return entry;
}

Powered by Google App Engine
This is Rietveld 408576698