Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html

Issue 2635023002: [tracing] Support new heap dump format (Closed)
Patch Set: remove it again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
index 32dec9fdbee1a85899a22131728bc2ee36ce1d7c..f441b295c4f410ba92d485972a2d76f1741653a6 100644
--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html
@@ -190,16 +190,17 @@ tr.exportTo('tr.ui.analysis', function() {
convertStackFrameNodeDimensionToChildDict_: function(
stackFrameNode, dimensionIndex) {
var childDict = {};
-
var displayedChildrenTotalSize = 0;
var displayedChildrenTotalCount = 0;
var hasDisplayedChildren = false;
var allDisplayedChildrenHaveDisplayedCounts = true;
for (var child of stackFrameNode.children[dimensionIndex].values()) {
- if (child.values[0].totalState < this.minDisplayedTotalState_)
+ if (child.values[0].totalState < this.minDisplayedTotalState_) {
continue;
- if (child.values[1].totalState < this.minDisplayedTotalState_)
+ }
+ if (child.values[1].totalState < this.minDisplayedTotalState_) {
allDisplayedChildrenHaveDisplayedCounts = false;
+ }
childDict[child.title[dimensionIndex]] = child;
displayedChildrenTotalSize += child.values[0].total;
displayedChildrenTotalCount += child.values[1].total;
@@ -431,11 +432,16 @@ tr.exportTo('tr.ui.analysis', function() {
var objectTypeNamePath = objectTypeName === undefined ?
[] : [objectTypeName];
+ var valueKind = entry.valuesAreSelf ?
+ MultiDimensionalViewBuilder.ValueKind.SELF :
+ MultiDimensionalViewBuilder.ValueKind.TOTAL;
+
builder.addPath([stackTracePath, objectTypeNamePath],
[entry.size, entry.count],
- MultiDimensionalViewBuilder.ValueKind.TOTAL);
+ valueKind);
}
+ builder.complete = heapDump.isComplete;
this.cachedBuilders_.set(heapDump, builder);
return builder;
},

Powered by Google App Engine
This is Rietveld 408576698