Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2635003002: [wasm] [codestyle] Fix pointer alignment in wasm-debug.cc (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [codestyle] Fix pointer alignment in wasm-debug.cc Our .clang-format is derived on the Google style, which sets PointerAlignment to left (e.g. "Type* name"), but sets DerivePointerAlignment to true. Once we started with the wrong style, this made all new code in wasm-debug.cc use PointerAlignment=right, resulting in lots of code using the wrong style. For this CL, I ran clang-format -style="{DerivePointerAlignment: false, BasedOnStyle: \ Google}" -i src/wasm/wasm-debug.cc R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2635003002 Cr-Commit-Position: refs/heads/master@{#42380} Committed: https://chromium.googlesource.com/v8/v8/+/2702d0fbe31f58bebb26d1946295632648a85f7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M src/wasm/wasm-debug.cc View 9 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-16 15:19:24 UTC) #1
Clemens Hammacher
Maybe we should explicitly set DerivePointerAlignment to false in our .clang-format. WDYT? +jochen
3 years, 11 months ago (2017-01-16 15:20:59 UTC) #4
titzer
lgtm
3 years, 11 months ago (2017-01-16 15:25:04 UTC) #5
Clemens Hammacher
On 2017/01/16 at 15:20:59, Clemens Hammacher wrote: > Maybe we should explicitly set DerivePointerAlignment to ...
3 years, 11 months ago (2017-01-16 15:30:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635003002/1
3 years, 11 months ago (2017-01-16 15:31:04 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 15:44:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2702d0fbe31f58bebb26d1946295632648a...

Powered by Google App Engine
This is Rietveld 408576698