chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc - Issue 26350003: OLD: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

Issue 26350003: OLD: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix integer overflow w/ kint32max, add test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h » ('j') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

index 66c5c9d666b84210f13e2f182025c3003ad8b2d9..a0ba16931bdd734a6fce657404eeb7f7860f742b 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

@@ -34,7 +34,8 @@ BookmarkMenuController::BookmarkMenuController(Browser* browser,

const BookmarkNode* node,

int start_child_index)

: menu_delegate_(

- new BookmarkMenuDelegate(browser, page_navigator, parent, 1)),

+ new BookmarkMenuDelegate(browser, page_navigator, parent, 1,

+ kint32max)),

node_(node),

observer_(NULL),

for_drop_(false),