chrome/browser/ui/toolbar/wrench_menu_model.h - Issue 26350003: OLD: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.h

Issue 26350003: OLD: reland "views: change WrenchMenu to use each model's command ID's when creating MenuItemView's" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix integer overflow w/ kint32max, add test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/wrench_menu_model.h

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.h b/chrome/browser/ui/toolbar/wrench_menu_model.h

index 1bf9bb0a01cd755b21501a9ade3e2388270c34d6..159b219feffab318bfc1a08bfefb00a9f63a3914 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.h

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.h

@@ -79,6 +79,16 @@ class WrenchMenuModel : public ui::SimpleMenuModel,

public TabStripModelObserver,

public content::NotificationObserver {

public:

+ // Range of command ID's to use for the items representing bookmarks in the

+ // bookmark menu, must not overlap with that for recent tabs submenu.

+ static const int kMinBookmarkCommandId = 1;

+ static const int kMaxBookmarkCommandId = 1000;

+ // Range of command ID's to use for the items in the recent tabs submenu, must

+ // not overlap with that for bookmarks.

+ static const int kMinRecentTabsCommandId = 1001;

+ static const int kMaxRecentTabsCommandId = 1200;

// TODO: remove |is_new_menu|.

WrenchMenuModel(ui::AcceleratorProvider* provider,

Browser* browser,