Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2634963002: Make Wasm objects API objects (Closed)

Created:
3 years, 11 months ago by rossberg
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Wasm objects API objects R=titzer@chromium.org BUG=680833 Review-Url: https://codereview.chromium.org/2634963002 Cr-Commit-Position: refs/heads/master@{#42370} Committed: https://chromium.googlesource.com/v8/v8/+/22abb8b1235d22afd8cac87682188d1321160b53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/wasm/wasm-js.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
rossberg
3 years, 11 months ago (2017-01-16 12:20:53 UTC) #1
titzer
LGTM
3 years, 11 months ago (2017-01-16 12:28:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634963002/1
3 years, 11 months ago (2017-01-16 12:30:28 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 12:58:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/22abb8b1235d22afd8cac87682188d13211...

Powered by Google App Engine
This is Rietveld 408576698