Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2634953002: [turbofan] Don't merge PropertyAccessInfos with different field maps. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't merge PropertyAccessInfos with different field maps. BUG=chromium:679378 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2634953002 Cr-Commit-Position: refs/heads/master@{#42365} Committed: https://chromium.googlesource.com/v8/v8/+/64963e1b146fb457ad2bc331bbba7339e0d67987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/compiler/access-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-679378.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-16 10:47:47 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-16 11:45:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634953002/1
3 years, 11 months ago (2017-01-16 11:45:55 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 11:47:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/64963e1b146fb457ad2bc331bbba7339e0d...

Powered by Google App Engine
This is Rietveld 408576698