Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2634943002: [wasm] Add the 'end' opcode at the end of the fuzzer input (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add the 'end' opcode at the end of the fuzzer input Without the end opcode at the end of a function nearly every fuzzer input would be invalid and test nothing. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2634943002 Cr-Commit-Position: refs/heads/master@{#42363} Committed: https://chromium.googlesource.com/v8/v8/+/a686de07b12b55ba919a75bfa0f1e1728c440c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/fuzzer/wasm-call.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/fuzzer/wasm-code.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 11 months ago (2017-01-16 10:37:54 UTC) #1
titzer
On 2017/01/16 10:37:54, ahaas wrote: LGTM
3 years, 11 months ago (2017-01-16 10:50:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634943002/1
3 years, 11 months ago (2017-01-16 11:25:46 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 11:27:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a686de07b12b55ba919a75bfa0f1e1728c4...

Powered by Google App Engine
This is Rietveld 408576698