Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2634933002:
Remove implicit dependency between test cases. (Closed)
DescriptionRemove implicit dependency between test cases.
Accessibility keyboard enabled flags is not reset in |CloseKeyboard|
test case accidentally and |FloatingKeyboardShowOnFirstTap| test
depends on this behavior. This causes test failures when test execution
order changes by adding test cases.
TEST=n/a; no behavior change.
BUG=681007
Review-Url: https://codereview.chromium.org/2634933002
Cr-Commit-Position: refs/heads/master@{#443905}
Committed: https://chromium.googlesource.com/chromium/src/+/485cef68ecb7672a26df161f224d1f5e4a72dfaa
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhanada@chromium.org changed reviewers: + bshe@chromium.org
Hi bshe, PTAL.
Description was changed from ========== Remove implicit dependency between test cases. Accessibility keyboard enabled flags is not reset in |CloseKeyboard| test case accidentally and |FloatingKeyboardShowOnFirstTap| test depends on this behavior. This causes test failures when test execution order changes by adding test cases. TEST=n/a; no behavior change. ========== to ========== Remove implicit dependency between test cases. Accessibility keyboard enabled flags is not reset in |CloseKeyboard| test case accidentally and |FloatingKeyboardShowOnFirstTap| test depends on this behavior. This causes test failures when test execution order changes by adding test cases. TEST=n/a; no behavior change. BUG=681007 ==========
On 2017/01/16 10:14:41, yhanada wrote: > Hi bshe, PTAL. lgtm
The CQ bit was checked by yhanada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/16 15:06:36, bshe wrote: > On 2017/01/16 10:14:41, yhanada wrote: > > Hi bshe, PTAL. > > lgtm Thanks for the review!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhanada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org Link to the patchset: https://codereview.chromium.org/2634933002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484583574456060,
"parent_rev": "d080cefe5fb764633daedd060b4b8adec5d91a57", "commit_rev":
"485cef68ecb7672a26df161f224d1f5e4a72dfaa"}
Message was sent while issue was closed.
Description was changed from ========== Remove implicit dependency between test cases. Accessibility keyboard enabled flags is not reset in |CloseKeyboard| test case accidentally and |FloatingKeyboardShowOnFirstTap| test depends on this behavior. This causes test failures when test execution order changes by adding test cases. TEST=n/a; no behavior change. BUG=681007 ========== to ========== Remove implicit dependency between test cases. Accessibility keyboard enabled flags is not reset in |CloseKeyboard| test case accidentally and |FloatingKeyboardShowOnFirstTap| test depends on this behavior. This causes test failures when test execution order changes by adding test cases. TEST=n/a; no behavior change. BUG=681007 Review-Url: https://codereview.chromium.org/2634933002 Cr-Commit-Position: refs/heads/master@{#443905} Committed: https://chromium.googlesource.com/chromium/src/+/485cef68ecb7672a26df161f224d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/485cef68ecb7672a26df161f224d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
