Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2634893003: Experiment with blocking resolution of HTTP URLs containing '\n' and '<'. (Closed)

Created:
3 years, 11 months ago by Mike West
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experiment with blocking resolution of HTTP URLs containing '\n' and '<'. Following up on the metrics added in https://codereview.chromium.org/2629393002, this patch adds a flag that will prevent URL resolution if the URL string contains a raw newline and less than sign. It also refines the metrics by excluding non-HTTP (e.g. `data:`, `javascript:`, `file:`) URLs, as those are quite likely to contain `<`, and quite unlikely to result in exfiltration (as they don't hit the network). Let's see how the data looks. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/rOs6YRyBEpw/D3pzVwGJAgAJ BUG=680970 Review-Url: https://codereview.chromium.org/2634893003 Cr-Commit-Position: refs/heads/master@{#444040} Committed: https://chromium.googlesource.com/chromium/src/+/cd87dfc6f638a6d64b2311d35a58cb1969116915

Patch Set 1 #

Patch Set 2 : yay #

Patch Set 3 : yay #

Patch Set 4 : Culling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/dangling-markup/resources/helper.js View 2 chunks +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/dangling-markup/src-attribute.html View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 1 chunk +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (22 generated)
Mike West
WDYT, Jochen?
3 years, 11 months ago (2017-01-17 08:57:37 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-17 09:31:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634893003/60001
3 years, 11 months ago (2017-01-17 13:14:35 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:43:01 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cd87dfc6f638a6d64b2311d35a58...

Powered by Google App Engine
This is Rietveld 408576698