Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2634663002: Add WalletCardClass to WalletMaskedCreditCard (Closed)

Created:
3 years, 11 months ago by Jared Saul
Modified:
3 years, 11 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WalletCardClass to WalletMaskedCreditCard BUG=602665 Review-Url: https://codereview.chromium.org/2634663002 Cr-Commit-Position: refs/heads/master@{#444453} Committed: https://chromium.googlesource.com/chromium/src/+/cb2e4909f9c62830cbebc0ad8e74899d35a7df00

Patch Set 1 #

Patch Set 2 : Add card_class to proto_visitors.h #

Patch Set 3 : Change UNKNOWN to UNKNOWN_CARD_CLASS to satisfy C++ scoping rules #

Patch Set 4 : Add WalletCardClass to proto_enum_conversions files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M components/sync/protocol/autofill_specifics.proto View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_enum_conversions.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_enum_conversions.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_visitors.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Jared Saul
For b/34165331 (please let me know if there's a corresponding Chromium bug). PTAL, thank you!
3 years, 11 months ago (2017-01-13 23:10:39 UTC) #3
please use gerrit instead
LGTM. Chromium bug is http://crbug.com/602665.
3 years, 11 months ago (2017-01-16 17:50:00 UTC) #4
Nicolas Zea
lgtm
3 years, 11 months ago (2017-01-18 01:16:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634663002/20001
3 years, 11 months ago (2017-01-18 17:42:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/23102) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-18 17:49:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634663002/40001
3 years, 11 months ago (2017-01-18 18:00:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/139191)
3 years, 11 months ago (2017-01-18 18:09:29 UTC) #16
Jared Saul
I added proto_enum_conversions.h and proto_enum_conversions.cc to this change to satisfy the trybots. Would one of ...
3 years, 11 months ago (2017-01-18 19:25:08 UTC) #19
please use gerrit instead
lgtm
3 years, 11 months ago (2017-01-18 19:27:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634663002/60001
3 years, 11 months ago (2017-01-18 20:03:26 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:10:55 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cb2e4909f9c62830cbebc0ad8e74...

Powered by Google App Engine
This is Rietveld 408576698