Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2634573002: [foozzie] Fix comparison baseline after asm switch (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Fix comparison baseline after asm switch Now that validate asm is on by default, the comparison fullcode with ignition_staging does nothing in regards to validate_asm. BUG=chromium:673246 NOTRY=true TBR=bradnelson@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2634573002 Cr-Commit-Position: refs/heads/master@{#42335} Committed: https://chromium.googlesource.com/v8/v8/+/936f79d9242c7450efa5a34edbb77404700ac5f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/foozzie/testdata/failure_output.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/foozzie/v8_foozzie.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
PTAL
3 years, 11 months ago (2017-01-13 14:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634573002/1
3 years, 11 months ago (2017-01-13 15:02:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/936f79d9242c7450efa5a34edbb77404700ac5f3
3 years, 11 months ago (2017-01-13 15:04:31 UTC) #8
titzer
3 years, 11 months ago (2017-01-13 16:42:48 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698