Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: src/debug/debug.h

Issue 2634523002: [debugger] whitelist some builtins as side-effect free. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | src/debug/debug-evaluate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 4312533f59c258f65d31480942f2838dc3d9f6b2..facbbc3f79b6e757e41d492b0a91d239077c1913 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -588,7 +588,9 @@ class Debug {
// Check whether there are commands in the command queue.
inline bool has_commands() const { return !command_queue_.IsEmpty(); }
- inline bool ignore_events() const { return is_suppressed_ || !is_active_; }
+ inline bool ignore_events() const {
+ return is_suppressed_ || !is_active_ || isolate_->needs_side_effect_check();
+ }
inline bool break_disabled() const {
return break_disabled_ || in_debug_event_listener_;
}
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | src/debug/debug-evaluate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698