Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: src/debug/debug.h

Issue 2634523002: [debugger] whitelist some builtins as side-effect free. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | src/debug/debug-evaluate.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 581
582 void UpdateState(); 582 void UpdateState();
583 void UpdateHookOnFunctionCall(); 583 void UpdateHookOnFunctionCall();
584 void Unload(); 584 void Unload();
585 void SetNextBreakId() { 585 void SetNextBreakId() {
586 thread_local_.break_id_ = ++thread_local_.break_count_; 586 thread_local_.break_id_ = ++thread_local_.break_count_;
587 } 587 }
588 588
589 // Check whether there are commands in the command queue. 589 // Check whether there are commands in the command queue.
590 inline bool has_commands() const { return !command_queue_.IsEmpty(); } 590 inline bool has_commands() const { return !command_queue_.IsEmpty(); }
591 inline bool ignore_events() const { return is_suppressed_ || !is_active_; } 591 inline bool ignore_events() const {
592 return is_suppressed_ || !is_active_ || isolate_->needs_side_effect_check();
593 }
592 inline bool break_disabled() const { 594 inline bool break_disabled() const {
593 return break_disabled_ || in_debug_event_listener_; 595 return break_disabled_ || in_debug_event_listener_;
594 } 596 }
595 597
596 void clear_suspended_generator() { 598 void clear_suspended_generator() {
597 thread_local_.suspended_generator_ = Smi::kZero; 599 thread_local_.suspended_generator_ = Smi::kZero;
598 } 600 }
599 601
600 bool has_suspended_generator() const { 602 bool has_suspended_generator() const {
601 return thread_local_.suspended_generator_ != Smi::kZero; 603 return thread_local_.suspended_generator_ != Smi::kZero;
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 Handle<Code> code); 877 Handle<Code> code);
876 static bool DebugBreakSlotIsPatched(Address pc); 878 static bool DebugBreakSlotIsPatched(Address pc);
877 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 879 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
878 }; 880 };
879 881
880 882
881 } // namespace internal 883 } // namespace internal
882 } // namespace v8 884 } // namespace v8
883 885
884 #endif // V8_DEBUG_DEBUG_H_ 886 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | src/debug/debug-evaluate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698