Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2634513004: Replace unique_ptr.reset/release with std::move (Closed)

Created:
3 years, 11 months ago by Sunny
Modified:
3 years, 11 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset/release with std::move R=gavinp@chromium.org BUG=644626 Review-Url: https://codereview.chromium.org/2634513004 Cr-Commit-Position: refs/heads/master@{#445735} Committed: https://chromium.googlesource.com/chromium/src/+/437df5cde1efb13ea51c97e4133c2fd1b1fd654c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quartc/quartc_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Sunny
PTAL, thanks~
3 years, 11 months ago (2017-01-13 16:56:32 UTC) #1
gavinp
lgtm
3 years, 11 months ago (2017-01-24 14:46:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634513004/1
3 years, 11 months ago (2017-01-24 14:47:09 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 15:51:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/437df5cde1efb13ea51c97e4133c...

Powered by Google App Engine
This is Rietveld 408576698