third_party/WebKit/Source/core/layout/ScrollAnchor.cpp - Issue 2634493007: Introduce LayoutObject::AncestorSkipInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

Issue 2634493007: Introduce LayoutObject::AncestorSkipInfo. (Closed)

Patch Set: Turn AncestorSkipInfo into a proper class with private data members. Only look for filters when tol… Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

diff --git a/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp b/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

index fdd8e69a9b504b23314bf356dc0de41d88653353..84badd5c5795f83e255c1b6f76b63f61b0f38687 100644

--- a/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

+++ b/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp

@@ -119,9 +119,9 @@ static bool candidateMayMoveWithScroller(const LayoutObject* candidate,

return false;

}

- bool skippedByContainerLookup = false;

- candidate->container(scrollerLayoutBox(scroller), &skippedByContainerLookup);

- return !skippedByContainerLookup;

+ LayoutObject::AncestorSkipInfo skipInfo(scrollerLayoutBox(scroller));

+ candidate->container(&skipInfo);

+ return !skipInfo.ancestorSkipped();

}

ScrollAnchor::ExamineResult ScrollAnchor::examine(

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp ('k') | no next file » | no next file with comments »