Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

Issue 2634493007: Introduce LayoutObject::AncestorSkipInfo. (Closed)
Patch Set: Turn AncestorSkipInfo into a proper class with private data members. Only look for filters when tol… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
index e870cd1b6ef130a4598d27a3e3643d4db96f7f0c..10cd9e977478096c7ba27eefd8e83055a8e5be3b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
@@ -169,13 +169,13 @@ TEST_F(LayoutObjectTest, FloatUnderInline) {
EXPECT_EQ(container, floating->container());
EXPECT_EQ(container, floating->containingBlock());
- bool ancestorSkipped = false;
- EXPECT_EQ(container, floating->container(layeredSpan, &ancestorSkipped));
- EXPECT_TRUE(ancestorSkipped);
+ LayoutObject::AncestorSkipInfo skipInfo(layeredSpan);
+ EXPECT_EQ(container, floating->container(&skipInfo));
+ EXPECT_TRUE(skipInfo.ancestorSkipped());
- ancestorSkipped = false;
- EXPECT_EQ(container, floating->container(container, &ancestorSkipped));
- EXPECT_FALSE(ancestorSkipped);
+ skipInfo = LayoutObject::AncestorSkipInfo(container);
+ EXPECT_EQ(container, floating->container(&skipInfo));
+ EXPECT_FALSE(skipInfo.ancestorSkipped());
}
TEST_F(LayoutObjectTest, MutableForPaintingClearPaintFlags) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698