Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2634493006: Implement Internals::mainThreadScrollingReasons for SPV2 (Closed)

Created:
3 years, 11 months ago by pdr.
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, yigu
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Internals::mainThreadScrollingReasons for SPV2 This patch returns FrameView's main thread scrolling reasons as a string which is used by Internals::mainThreadScrollingReasons. TEST=compositing/layer-creation/iframe-background-attachment-fixed.html with --additional-driver-flag=--enable-slimming-paint-v2 BUG=671838 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2634493006 Cr-Commit-Position: refs/heads/master@{#443744} Committed: https://chromium.googlesource.com/chromium/src/+/9bf0adfb29b2f4c92c658a31d5562cded817746b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
pdr.
3 years, 11 months ago (2017-01-13 23:04:10 UTC) #8
chrishtr
lgtm
3 years, 11 months ago (2017-01-14 00:36:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634493006/1
3 years, 11 months ago (2017-01-14 00:38:26 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 00:51:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bf0adfb29b2f4c92c658a31d556...

Powered by Google App Engine
This is Rietveld 408576698