Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2634493005: MD Settings: Site exceptions, close action menu when list changes. (Closed)

Created:
3 years, 11 months ago by dpapad
Modified:
3 years, 11 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Site exceptions, close action menu when list changes. BUG=680455 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2634493005 Cr-Commit-Position: refs/heads/master@{#443747} Committed: https://chromium.googlesource.com/chromium/src/+/1c6b81a4a47c4b9a5f31a65ca0f34e1edc853c35

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Adding test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/browser/resources/settings/site_settings/site_list.js View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/site_list_tests.js View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
dpapad
3 years, 11 months ago (2017-01-13 21:50:53 UTC) #9
dschuyler
lgtm
3 years, 11 months ago (2017-01-14 00:40:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634493005/40001
3 years, 11 months ago (2017-01-14 00:48:43 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 00:54:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c6b81a4a47c4b9a5f31a65ca0f3...

Powered by Google App Engine
This is Rietveld 408576698