DescriptionRevert of Perform InterfaceProviderSpec intersection in the ServiceManager (patchset #12 id:220001 of https://codereview.chromium.org/2610853013/ )
Reason for revert:
This CL is causing chrome --mash to fail to start up on Chromebook hardware. See https://bugs.chromium.org/p/chromium/issues/detail?id=680700
I'm not sure why our existing test coverage doesn't catch this. Let me know if I can help manually test a future patch.
Original issue's description:
> Perform InterfaceProviderSpec intersection in the ServiceManager.
>
> . Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe.
> . Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change.
>
> Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Review-Url: https://codereview.chromium.org/2610853013
> Cr-Commit-Position: refs/heads/master@{#443119}
> Committed: https://chromium.googlesource.com/chromium/src/+/e70e635ab325eede70d564b995130583bb3404ce
TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2634493002
Cr-Commit-Position: refs/heads/master@{#443473}
Committed: https://chromium.googlesource.com/chromium/src/+/b7a17d377dd14b1651ba882df608b87e11a35308
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|