Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2634493002: Revert of Perform InterfaceProviderSpec intersection in the ServiceManager (Closed)

Created:
3 years, 11 months ago by James Cook
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Perform InterfaceProviderSpec intersection in the ServiceManager (patchset #12 id:220001 of https://codereview.chromium.org/2610853013/ ) Reason for revert: This CL is causing chrome --mash to fail to start up on Chromebook hardware. See https://bugs.chromium.org/p/chromium/issues/detail?id=680700 I'm not sure why our existing test coverage doesn't catch this. Let me know if I can help manually test a future patch. Original issue's description: > Perform InterfaceProviderSpec intersection in the ServiceManager. > > . Introduces a parallel flow in ServiceManager to Connect called BindInterface which carries (via ConnectParams) interface name and pipe. > . Introduces an OnBindInterface() method to mojom::Service. In ServiceContext, this just calls through to OnConnect still since updating callsites is a pretty large task for a subsequent change. > > Note that policy checking is still happening in the client - there was no easy way to avoid this without adding an unsafe mode to InterfaceRegistry that skips the check that I'd be concerned might be misused. And IR should probably just die once this work is complete anyway. > > R=rockot@chromium.org,tsepez@chromium.org > > Review-Url: https://codereview.chromium.org/2610853013 > Cr-Commit-Position: refs/heads/master@{#443119} > Committed: https://chromium.googlesource.com/chromium/src/+/e70e635ab325eede70d564b995130583bb3404ce TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2634493002 Cr-Commit-Position: refs/heads/master@{#443473} Committed: https://chromium.googlesource.com/chromium/src/+/b7a17d377dd14b1651ba882df608b87e11a35308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -296 lines) Patch
M services/service_manager/connect_params.h View 2 chunks +0 lines, -28 lines 0 comments Download
M services/service_manager/public/cpp/interface_registry.h View 1 chunk +0 lines, -10 lines 0 comments Download
M services/service_manager/public/cpp/lib/interface_registry.cc View 3 chunks +26 lines, -23 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 2 chunks +6 lines, -35 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 chunk +0 lines, -10 lines 0 comments Download
M services/service_manager/public/interfaces/service.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
M services/service_manager/service_manager.cc View 11 chunks +106 lines, -162 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
James Cook
Created Revert of Perform InterfaceProviderSpec intersection in the ServiceManager
3 years, 11 months ago (2017-01-13 02:22:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634493002/1
3 years, 11 months ago (2017-01-13 02:23:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:25:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7a17d377dd14b1651ba882df608...

Powered by Google App Engine
This is Rietveld 408576698